Simplify SortedDocIDMerger.next()#16073
Merged
Merged
Conversation
- Drop the `else if (queue.size() > 0)` guard in next(): the queue is guaranteed non-empty when that branch is reached, since an empty queue sets queueMinDocID to NO_MORE_DOCS and any valid nextDoc would have taken the fast path. Add a comment explaining the invariant. - Simplify reset() by handling the first sub before the loop, removing the `boolean first` flag and the dead `current = null` assignment.
ChrisHegarty
pushed a commit
that referenced
this pull request
May 22, 2026
The else if (queue.size() > 0) guard is always true when reached: an empty queue sets queueMinDocID to NO_MORE_DOCS, so any valid nextDoc satisfies nextDoc < queueMinDocID and takes the fast path first. Replace with else and add a comment explaining why the queue is never empty at that point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
else if (queue.size() > 0)guard is always true when reached:an empty queue sets queueMinDocID to NO_MORE_DOCS, so any valid nextDoc
satisfies nextDoc < queueMinDocID and takes the fast path first. Replace
with
elseand add a comment explaining why the queue is never emptyat that point.